Commit Graph

12 Commits

Author SHA1 Message Date
Jan Pokorný
8a24f99b53
build: release.mk: deal with trailing whitespace-to-comment-delimiter
... that is preserved by design, see:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/make.html#tag_20_76_13_05

> string1 = [string2]
> [...]
> where string2 is defined as all characters, if any, after the
> <equals-sign>, up to a comment character ( '#' ) or an unescaped
> <newline>. Any <blank> characters immediately before or after the
> <equals-sign> shall be ignored.

Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
2017-12-14 16:17:33 +01:00
Jan Pokorný
37b4e73a27 Typo fix + qb blackbox(8) tweaks and extension + gitignore follow-up (#262)
* Fix typo: occur{ -> r}(ed|ing)

* doc: qb-blackbox(8): cosmetic touches

* doc: qb-blackbox(8): add "Portability notes" subsection

* Low: build: git-ignore build-aux/release.mk "overhead" files
This should have been part of ae5138d.

* build: release.mk: ensure checksum file generated even w/o signing
This should have been part of d20e48a.

Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
2017-08-07 10:21:25 +01:00
Jan Pokorný
4af8966a57
build: release.mk: reflect current release publishing practice
In the previous maintenance epoch, libqb release files used to be
published at fedorahosted.org[1], but since the sunset of that
hosting[2] (original files now preserved[3] at [4]), only GitHub is
used to host the releases.  In fact, there was a short overlap period
(comprising just v0.17.2 tag; beware, prior archives are just autoserved
directly from the tree at that particular tag), until Chrissie decided
there's no point to handle both[5] (providentially, long before that
sunset of the former).

Unfortunately, publish-by-scp convenience of fedorahosted.org won't fly
with GitHub that insists on the (primarily REST) API to get things
automated, so update "publish" recipe to that effect, providing some
hints on possible adaption of the process.

Also, turn "git push --tags" to a bit safer "git push --follow-tags"
for good measure.

[1] https://fedorahosted.org/releases/q/u/quarterback/ (now defunct)
[2] https://lists.fedoraproject.org/archives/list/announce@lists.fedoraproject.org/message/BWSMCGZPPNG3JOCFQ6Z74MIBU7FG3KGB/
[3] http://oss.clusterlabs.org/pipermail/developers/2017-February/000438.html
[4] http://releases.pagure.org/ClusterLabs/libqb/
[5] http://oss.clusterlabs.org/pipermail/developers/2016-April/000198.html

Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
2017-06-13 19:55:45 +02:00
Jan Pokorný
f7e6a766fb
build: release.mk: simplify the default goal, declare .PHONY targets
The default goal line now serves mainly the documentation purpose,
otherwise it could be squashed down to "sign" target.

Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
2017-06-13 18:43:26 +02:00
Jan Pokorný
d20e48a0b2
build: release.mk: move soft guard for no GPG key up the supply chain
It also means the missing key specification is now a hard error when
ASCII armored files are to be created (directly or by other rules).

Leveraging the previous commit, it is now unnecessary to guard against
release mode not being requested, so this guard is dropped completely
in the transition, allowing for the full-fledged (incl. GPG signing)
release delivery testing without mangling with in-tree tags.

To allow "sign" target to (possibly eventually) become the implicit goal
even if "gpgsignkey" variable is explicitly unspecified, make it depend
on "tarballs".

Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
2017-06-13 18:37:30 +02:00
Jan Pokorný
ae5138d3e0
build: release.mk: fix no-release conflict (implied-required version)
Previously, generating custom versioned tarballs without requiring
a "release" (which comprises also tagging hence in turn making the
implied version match the required one as desired) would not allow
to test the release routines thoroughly incl. GPG signing.
Unfortunately, allowing for a temporary tag is prone to accidentally
slipping it to the distributed tree, so that should rather be avoided.
Now it can.

Another step to blur the boundaries between whether "release" is
specified or not is make checksums file generated unconditionally.

Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
2017-06-13 18:26:13 +02:00
Jan Pokorný
69fe0c3f16
build: release.mk: simplify/generalize GPG signing rule
Pattern matching is a brilliant DRY technique in makefile's composition,
so it would be a pity to miss such a nonconflicting application related
to the previous, "sign tarballs" commit.

For that to work reliably for the complete dependency backtrack, though,
a pre-existing issue with parallelized work on the prerequisites needs
to be fixed first.  The problem was "tarballs" (phony) target missing
in the linearized supply chain for the signed tarballs, as opposed to
to supply chain for the checksums file that can be worked on in an
(unordered!) interleave with the work on these signed tarballs.
Hence fix this race condition by stretching "tarballs" target as
progress barrier (using it as a prerequisite) uniformly for all the
deliverables that are going to be signed (used to be just for "sha256"
target)).  And when at it, make "deliverables" variable list them
conveniently (along with reformatting definitions of other variables
for uniformity).

Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
2017-06-13 17:58:51 +02:00
Christine Caulfield
80cfb8f461 sign tarballs 2017-06-08 15:09:10 +01:00
David Vossel
3f7de65785 Low: release.mk: update gpg public key 2014-08-26 23:04:13 -05:00
David Vossel
1a48037fe8 Update release gpg sign key 2013-07-25 13:11:21 -05:00
The Quarterback Library Release Team
ea704d5821 Set the gpgsignkey in release.mk
Signed-off-by: The Quarterback Library Release Team <quarterback-devel@fedorahosted.org>
2011-01-31 14:10:14 +11:00
Angus Salkeld
487f611cb9 BUILD: improve the rpm building
copy corosync's rpm build system.

Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
2011-01-09 17:22:24 +11:00