Proxmox-Port/libqb
1
0
Fork 0
mirror of https://salsa.debian.org/ha-team/libqb synced 2026-08-17 07:43:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Set correct ownership if qb_ipcs_connection_auth_set() has been used (#382)

Browse Source 
When qb_ipcs_connection_auth_set() has been used, the ownership of the
temp directory initially set by handle_new_connection() must be updated
as well.
This commit is contained in:
Jonas Witschel 2020-02-12 14:47:13 +00:00 committed by GitHub
parent c5cb0db0f2
commit dd22a1811f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Makefile.am
View File

@ -151,7 +151,7 @@ ALL_LINT_FLAGS = $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(DEB_INCLUDES) \
# ipc_setup.c: (in function qb_ipcc_us_setup_connect)
# ipc_setup.c:479:2: Return value (type int32_t) ignored: qb_ipc_us_ready(...
# ipc_setup.c:494:2: Return value (type int32_t) ignored: qb_ipc_auth_cred...
SPLINT_SUMMARY_EXP = " 2 code warnings"
SPLINT_SUMMARY_EXP = " 3 code warnings"
run_splint.sh: $(top_srcdir)/configure.ac
@echo '$(SPLINT) $(ALL_LINT_FLAGS) \' > $@-t

10
lib/ipc_shm.c
View File

@ -283,6 +283,8 @@ qb_ipcs_shm_connect(struct qb_ipcs_service *s,
struct qb_ipc_connection_response *r)
{
int32_t res;
char dirname[PATH_MAX];
char *slash;
qb_util_log(LOG_DEBUG, "connecting to client [%d]", c->pid);
@ -293,6 +295,14 @@ qb_ipcs_shm_connect(struct qb_ipcs_service *s,
snprintf(r->event, NAME_MAX, "%s-event-%s",
c->description, s->name);
/* Set correct ownership if qb_ipcs_connection_auth_set() has been used */
strlcpy(dirname, c->description, sizeof(dirname));
slash = strrchr(dirname, '/');
if (slash) {
*slash = '\0';
(void)chown(dirname, c->auth.uid, c->auth.gid);
}
res = qb_ipcs_shm_rb_open(c, &c->request,
r->request);
if (res != 0) {